https://bugs.kde.org/show_bug.cgi?id=453450

            Bug ID: 453450
           Summary: Empty file being created even when receive operation
                    fails
           Product: kdeconnect
           Version: unspecified
          Platform: Android
                OS: Android 11.x
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: android-application
          Assignee: albertv...@gmail.com
          Reporter: jejoxe6...@topyte.com
  Target Milestone: ---

SUMMARY
If receive operation fails from the senders side even before any file data is
sent, then the receiver will create an empty file.

STEPS TO REPRODUCE
1. Grant all storage permission required to receive a file.
2. Send a file such that the receive operation fails due to some reason even
before any bytes are received at the receiver end.
3. Check the folder where the file would have been saved had it been received
correctly

OBSERVED RESULT
File of size 0 bytes is created.

EXPECTED RESULT
No file should be created.
Possible fix is to not call `openFile(...)` inside `if (numFiles == 1 &&
currentNetworkPacket.getBoolean("open", false))` at
https://invent.kde.org/network/kdeconnect-android/-/blob/master/src/org/kde/kdeconnect/Plugins/SharePlugin/CompositeReceiveFileJob.java#L218

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to