https://bugs.kde.org/show_bug.cgi?id=452596
Alexander Lohnau <alexander.loh...@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/plas |eworks/plasma-framework/com |ma/kdeplasma-addons/commit/ |mit/c90e49cc98769ca5b9275c0 |27710b95a3fd53019b4b053cbdf |89880b3d64f1689c5 |720354fd939d2 --- Comment #11 from Alexander Lohnau <alexander.loh...@gmx.de> --- Git commit 27710b95a3fd53019b4b053cbdf720354fd939d2 by Alexander Lohnau. Committed on 17/04/2022 at 04:45. Pushed by alex into branch 'Plasma/5.24'. Remove unneeded check for comic Dataengine being valid We do not really care, if the metadata of the plugin is valid, as long as we can properly create the dataengine from it. Test Plan: With plasma-frameworks master, and this on Plasma/5.24 based revision, the dataengine can properly be loaded. When intenitionally exporting a defunct plugin: ```cpp class Dummy : public QObject { Q_OBJECT public: Dummy(QObject *parent, const QVariantList &args) { } }; K_PLUGIN_CLASS_WITH_JSON(Dummy, "plasma-dataengine-comic.json") ``` The applet does not crash. M +2 -2 applets/comic/comic.cpp M +1 -1 applets/comic/comicarchivejob.cpp https://invent.kde.org/plasma/kdeplasma-addons/commit/27710b95a3fd53019b4b053cbdf720354fd939d2 -- You are receiving this mail because: You are watching all bug changes.