https://bugs.kde.org/show_bug.cgi?id=445922

Dmitry Kazakov <dimul...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
                   |hics/krita/commit/f23f9a6d9 |hics/krita/commit/2153baf0a
                   |90ee978803deb3e3dcaa1e482b1 |9762b3a56391dac76459ef4853f
                   |f9af                        |76e5

--- Comment #23 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 2153baf0a9762b3a56391dac76459ef4853f76e5 by Dmitry Kazakov.
Committed on 23/02/2022 at 08:48.
Pushed by dkazakov into branch 'krita/5.0'.

Fix a crash when opening LS dialog with all patterns filtered-out

If the currently (globally) active tag filters out all the resources,
then the selectors may fail to activate a resource from the user's
preset/style and end up returning a null pointer.

This patch just moves the concept of a "hidden" selection from
KisResourceItemChooser to KisPatternChooser.

Steps to reproduce:

1) In the global pattern chooser create a new tag, don't add any patterns to
that, activate the tag
2) See that the pattern selector doesn't have a any resources in it
3) Open the Layer Styles dialog. Click on the bevel style. See the crash.

M  +3    -3    libs/ui/dialogs/kis_dlg_layer_style.cpp
M  +6    -3    libs/ui/widgets/kis_pattern_chooser.cc
M  +1    -1    libs/ui/widgets/kis_pattern_chooser.h
M  +4    -3    plugins/generators/pattern/kis_wdg_pattern.cpp
M  +3    -3    plugins/paintops/libpaintop/kis_texture_option.cpp

https://invent.kde.org/graphics/krita/commit/2153baf0a9762b3a56391dac76459ef4853f76e5

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to