https://bugs.kde.org/show_bug.cgi?id=450444
Bug ID: 450444
Summary: First run gives ugly unable to load tileset/background
errors to user.
Product: kshisen
Version: unspecified
Platform: unspecified
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: schwar...@kde.org
Reporter: andy...@gmail.com
CC: kde-games-b...@kde.org
Target Milestone: ---
Created attachment 146859
--> https://bugs.kde.org/attachment.cgi?id=146859&action=edit
Proposed workaround.
SUMMARY
When starting kshisen for the first time on a fresh installation without
~/.config/kshisenrc in place,
STEPS TO REPRODUCE
1. rm ~/.config/kshisenrc
2. kshisen
OBSERVED RESULT
Two modal dialog boxes one after the other complaining about inability to load
tileset and background.
EXPECTED RESULT
No unusual error messages on first run.
SOFTWARE/OS VERSIONS
All
ADDITIONAL INFORMATION
kmahjongg (which uses the same tileset/background loading logic) actually as a
silent debug message in this situation, but in kshisen it is a user-facing
error dialog.
I have provided a proposed patch (untested, as I don't currently have the kde
build environment on this PC), but should be fairly straightforward. It only
silences the error in the case where the functions were asked to load an
"empty" background/tileset, and then it loads the default. It still surfaces
an error if the user has deleted an explicitly defined tileset/background and
they can no longer be found.
An alternative would be to make the error completely silent like in kmahjongg.
I felt this was a better approach to keep with the idea of the dialog, but
without it happening on first run (which simply gives a bad initial experience
and feels like KDE/distribution install and/or game is buggy).
--
You are receiving this mail because:
You are watching all bug changes.
