https://bugs.kde.org/show_bug.cgi?id=432093
Ismael Asensio <isma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |isma...@gmail.com
--- Comment #16 from Ismael Asensio <isma...@gmail.com> ---
(In reply to EDeadLock from comment #13)
> @@ -485,7 +487,7 @@ void ModuleView::stateChanged()
> updatePageIconHeader(d->mPageWidget->currentPage());
>
> KCModuleProxy *moduleProxy =
> d->mPages.value(d->mPageWidget->currentPage());
> - d->mCustomHeader->setVisible(!moduleProxy ||
> !moduleProxy->realModule()->inherits("KCModuleQml"));
> + d->mCustomHeader->setVisible(false);
Hi there! You were right in this line causing the bug.
The reason you couldn't find "Header3" is because it is generated in QML by
modules that have already been ported to use that technology. There is code to
treat the three different cases (QML modules, QWidget modules when in Sidebar
View and QWidget modules when in Icon View), but that code wasn't always being
run, causing the bug.
The code in this class in general has been suffering from small incremental
changes which made it a little too un-manageable, so fixing one thing could
break a different one. I hope with a little refactor this is sorted out and not
many new surprises arise.
--
You are receiving this mail because:
You are watching all bug changes.
