https://bugs.kde.org/show_bug.cgi?id=436405

Yerrey Dev <yer...@protonmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/mult
                   |                            |imedia/elisa/commit/db4720e
                   |                            |7fa9e294a3916941749a83a0c38
                   |                            |45e344
         Resolution|---                         |FIXED

--- Comment #6 from Yerrey Dev <yer...@protonmail.com> ---
Git commit db4720e7fa9e294a3916941749a83a0c3845e344 by Yerrey Dev.
Committed on 27/01/2022 at 12:01.
Pushed by ngraham into branch 'master'.

Fixes issue of metadata/lyrics not updating when switching tracks

The issue is due to TrackMetadataModel::trackData not providing
track data for tracks with Database ID of 0, which are tracks that
are missing title metadata and are not added into elisaDatabase.db.
In the fix, we remove the ID check. This introduces another issue,
where in ContextView.qml onDatabaseIdChanged would not update the
metadata/lyrics because the ID of tracks without metadata would be
0, and it wouldn't trigger the refresh of tracks changing. To alleviate
this, we'll instead monitor the filename of the track playing, and
when that changes, we update trackdata by the file URL.

M  +1    -3    src/models/trackmetadatamodel.cpp
M  +3    -3    src/qml/ContextView.qml

https://invent.kde.org/multimedia/elisa/commit/db4720e7fa9e294a3916941749a83a0c3845e344

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to