https://bugs.kde.org/show_bug.cgi?id=341661

Matěj Laitl <ma...@laitl.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |http://commits.kde.org/amar
                   |                            |ok/6c49cfdfd97faa146ce7b0d8
                   |                            |e95ce2bf596f2b0d
         Resolution|---                         |FIXED

--- Comment #8 from Matěj Laitl <ma...@laitl.cz> ---
Git commit 6c49cfdfd97faa146ce7b0d8e95ce2bf596f2b0d by Matěj Laitl, on behalf
of Stefano Pettini.
Committed on 07/08/2016 at 09:34.
Pushed by laitl into branch 'master'.

Handle numeric fields properly in filter creation dialogs

Every numeric field, like length, disc number and track number, were
not properly parsed by the filter dialog or by the dynamic playlist
dialog into the textual query string used to then apply the filter.

The bug was due to what sounds like an "optimization" that swapped the
first and second value of a "between" condition, to make sure the
smaller value was always the first value and the larger always the
second. The problem was that this was applied also to non-between
conditions, actually swapping the lenth or disc number with 0, making
0 appear in the textual representation of the condition.

The fix makes sure that "optimization" is applied only in case of
actual "between" conditions, leaving the values "unoptimized" for any
other kind of condition (=, <, > and similar).

REVIEW: 128245

M  +2    -0    ChangeLog
M  +5    -1    src/widgets/MetaQueryWidget.cpp

http://commits.kde.org/amarok/6c49cfdfd97faa146ce7b0d8e95ce2bf596f2b0d

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to