https://bugs.kde.org/show_bug.cgi?id=366081

Martin Gräßlin <mgraess...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |http://commits.kde.org/kwin
                   |                            |/671740dc70c4d2fb091320c0da
                   |                            |564cf2ea6029b2
         Resolution|---                         |FIXED

--- Comment #11 from Martin Gräßlin <mgraess...@kde.org> ---
Git commit 671740dc70c4d2fb091320c0da564cf2ea6029b2 by Martin Gräßlin.
Committed on 03/08/2016 at 14:16.
Pushed by graesslin into branch 'master'.

Ensure that EffectsHandlerImpl::slotClientShown is only invoked once per Window

Summary:
This fixes a regression introduced with
a1afeded6ae63e47d39fc08480e929c0451c51e8.
The connections were setup every the windowShown signal got emitted.
This caused effects to get multiple singals and start multiple animations
which then do not get cancelled correctly.

The incorrect behavior was most visible in the translucency effect which
did not cancel the move animation and the window stayed translucent.

Test Plan:
New test case which simulates the behavior of the translucency
effect.

Reviewers: #kwin, #plasma, sebas

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D2346

M  +1    -0    autotests/integration/CMakeLists.txt
A  +3    -0    autotests/integration/effects/CMakeLists.txt
A  +185  -0    autotests/integration/effects/translucency_test.cpp    
[License: GPL (v2)]
M  +1    -1    effectloader.h
M  +1    -0    effects.cpp

http://commits.kde.org/kwin/671740dc70c4d2fb091320c0da564cf2ea6029b2

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to