https://bugs.kde.org/show_bug.cgi?id=445544

David Redondo <k...@david-redondo.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/plasma-systemmonitor/com |ma/plasma-systemmonitor/com
                   |mit/a96bc99a3650c3bf2e48ab1 |mit/50f6378144ed244b9c1cd3e
                   |287dc779dbba87c51           |325ecbe45dd7544d4

--- Comment #3 from David Redondo <k...@david-redondo.de> ---
Git commit 50f6378144ed244b9c1cd3e325ecbe45dd7544d4 by David Redondo.
Committed on 02/12/2021 at 14:54.
Pushed by davidre into branch 'Plasma/5.23'.

ApplicationsTable: Remove unneeded ProcessSortFilterModel

ProcessSortFilterModel handles filtering pids and to which user a process
belongs over a normal QSortFilterProxyModel. In doing so it also
sets the filterKeyColumn to nameColumn in findColumns(). Note that the name
of the name columns of the process and application table is different
("name" and "appName"), so the filterKeyColumn is also set by
ApplicationTableView.
However this is racey depending on when the binding is evaluated.
Since we don't need the extra features of the ProcessSortFilterModel we can use
the existing SortFilterProxyModel in charge of filtering columns (something
that
the ProcessSortFilterModel also did) to also handle the row filtering.
FIXED-IN:5.23.4


(cherry picked from commit a96bc99a3650c3bf2e48ab1287dc779dbba87c51)

M  +4    -11  
src/faces/applicationstable/contents/ui/ApplicationsTableView.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/50f6378144ed244b9c1cd3e325ecbe45dd7544d4

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to