[kdenlive] [Bug 438858] Missing support for GoPro .LRV files

[Alex Wigen]

https://bugs.kde.org/show_bug.cgi?id=438858

Alex Wigen <a...@wigen.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a...@wigen.net

--- Comment #4 from Alex Wigen <a...@wigen.net> ---
Hi there,

I've made a patch which enables using GoPro LRV proxy files in kdenlive. I
haven't got a dev environment for kdenlive but the patch is simple enough that
it should work.

I've tested proxies successfully using the update externalproxies.rc and
symlinking the GX high-res clips to GL names versions in order to work around
the missing prefix support.

i.e.:
for file in GX*MP4; do ln -s $file `echo $file | sed 's/GX/GL/'`; done

It would be great to get this into kdenlive as GoPro footage is very prevalent.


diff --git a/data/externalproxies.rc b/data/externalproxies.rc
index 41c617e0a..be733b975 100644
--- a/data/externalproxies.rc
+++ b/data/externalproxies.rc
@@ -8,4 +8,5 @@

 [proxy]
 Sony PXW=../Sub;;S03.MP4;../Clip;;.MXF
+GoPro LRV=./;GL;.LRV;./;GX;.MP4

diff --git a/src/bin/projectclip.cpp b/src/bin/projectclip.cpp
index ab6e2aedd..28a120b58 100644
--- a/src/bin/projectclip.cpp
+++ b/src/bin/projectclip.cpp
@@ -560,6 +560,10 @@ bool
ProjectClip::setProducer(std::shared_ptr<Mlt::Producer> producer)
                     QDir dir = info.absoluteDir();
                     dir.cd(externalParams.at(3));
                     QString fileName = info.fileName();
+                    if (fileName.startsWith(externalParams.at(1)) {
+                        filename.remove(0, externalParams.at(1).size());
+                        filename.prepend(externalParams.at(4));
+                    }
                     if (!externalParams.at(2).isEmpty()) {
                         fileName.chop(externalParams.at(2).size());
                     }
[alex@ole kdenlive]$ git cola
[alex@ole kdenlive]$ git show
commit e77b9248043f14206238d83a004f9f73f8150168 (HEAD -> master)
Author: Alexander Wigen <a...@wigen.net>
Date:   Sat Oct 9 23:22:51 2021 +1000

    Add prefix support for external proxies required for GoPro footage

    This also adds the GoPro LRV proxy format definition.

diff --git a/data/externalproxies.rc b/data/externalproxies.rc
index 41c617e0a..be733b975 100644
--- a/data/externalproxies.rc
+++ b/data/externalproxies.rc
@@ -8,4 +8,5 @@

 [proxy]
 Sony PXW=../Sub;;S03.MP4;../Clip;;.MXF
+GoPro LRV=./;GL;.LRV;./;GX;.MP4

diff --git a/src/bin/projectclip.cpp b/src/bin/projectclip.cpp
index ab6e2aedd..28a120b58 100644
--- a/src/bin/projectclip.cpp
+++ b/src/bin/projectclip.cpp
@@ -560,6 +560,10 @@ bool
ProjectClip::setProducer(std::shared_ptr<Mlt::Producer> producer)
                     QDir dir = info.absoluteDir();
                     dir.cd(externalParams.at(3));
                     QString fileName = info.fileName();
+                    if (fileName.startsWith(externalParams.at(1)) {
+                        filename.remove(0, externalParams.at(1).size());
+                        filename.prepend(externalParams.at(4));
+                    }
                     if (!externalParams.at(2).isEmpty()) {
                         fileName.chop(externalParams.at(2).size());
                     }

-- 
You are receiving this mail because:
You are watching all bug changes.