https://bugs.kde.org/show_bug.cgi?id=433510

--- Comment #8 from Paul Floyd <pjfl...@wanadoo.fr> ---

> In coregrind/m_debuginfo/storage.c we have:
> 
> +#if defined(VGO_freebsd)
> +   if (sym->size == 0)
> +      sym->size = 1;
> +#endif

The source of this has been lost in the mists of time. The oldest hg repo that
I have has this as the 2nd commit to storage.c. Commit 0 is an import from p4
and commit 1 is

summary:     - Add FreeBSD patches.

11 years ago. I have no trace of the patch (nothing in the port git log which
goes back a full 17 years).

I tried removing it and it seems to have no effect on the regression tests. I
think it's likely that this is no longer needed since this code must date back
to when GCC was used for the toolchain.

>  /* Number of file descriptors that Valgrind tries to reserve for
>     its own use - just a small constant. */
> +#if defined(VGO_freebsd)
> +#define N_RESERVED_FDS (20)
> +#else
>  #define N_RESERVED_FDS (12)
> +#endif
> 
> Why does FreeBSD need 8 more?

Exactly the same story as the previous change.

> I don't understand what SIGSYS is/does. This patch adds/clears it
> unconditionally, not just for freebsd. Is that correct?

Time to throw in the towel tonight, I'll look at that one tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to