https://bugs.kde.org/show_bug.cgi?id=430196

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/mult
                   |                            |imedia/elisa/commit/6089288
                   |                            |a629cfdf566b499224a403744ef
                   |                            |e3ff61
             Status|ASSIGNED                    |RESOLVED
   Version Fixed In|                            |21.12
         Resolution|---                         |FIXED

--- Comment #2 from Nate Graham <n...@kde.org> ---
Git commit 6089288a629cfdf566b499224a403744efe3ff61 by Nate Graham.
Committed on 08/10/2021 at 15:41.
Pushed by ngraham into branch 'master'.

Optional "favorite" style ratings

This commit adds an optional and off-by-default mode to display ratings
as "favorite"/"not favorite" rather than zero to five stars. This
supports people whose rating habits lead them to rate certain songs
with five stars but never use the 1, 2, 3, or 4 star ratings. In this
style, you're basically using the rating system to mark your favorite
songs rather than really rating them. This new mode makes that a bit
more natural for people who prefer that style.

In terms of implementation, when using this mode, songs with 5 stars are
considered to be "favorite" songs, and songs with any other rating are
considered to be "not favorite". Marking a song as a favorite internally
sets it to 5 stars, and it will appear as a 5-star song in other apps.

Note that I have used the existing star-style "rating" and
"rating-unrated" icons for this mode due to the absence of an adequate
pair of filled/unfilled heart icons in the Breeze icon theme. If those
are later added, it could be switched over to use them.
FIXED-IN: 21.12

M  +6    -1    src/elisa_core.kcfg
M  +7    -0    src/elisaapplication.cpp
M  +8    -0    src/elisaapplication.h
M  +15   -0    src/localFileConfiguration/elisaconfigurationdialog.cpp
M  +16   -0    src/localFileConfiguration/elisaconfigurationdialog.h
M  +50   -1    src/qml/ListBrowserDelegate.qml
M  +41   -11   src/qml/MediaTrackMetadataDelegate.qml
M  +18   -3    src/qml/NavigationActionBar.qml
M  +37   -2    src/qml/PlayListEntry.qml
M  +29   -0    src/qml/SettingsForm.qml

https://invent.kde.org/multimedia/elisa/commit/6089288a629cfdf566b499224a403744efe3ff61

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to