https://bugs.kde.org/show_bug.cgi?id=443475
Bug ID: 443475
Summary: Git Commit tool view doesn't display git commit errors
Product: kdevelop
Version: git master
Platform: Compiled Sources
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: VCS: Git
Assignee: kdevelop-bugs-n...@kde.org
Reporter: igor...@gmail.com
Target Milestone: ---
SUMMARY
Git Commit tool misbehaves when the `git commit` command it executes fails.
STEPS TO REPRODUCE
1. Clone a project with a commit hook that can fail. For example, KTextEditor.
2. Stage changes that the commit hook rejects. For example, misformat
KTextEditor code.
3. Enter a commit message and click the Commit button in the Git Commit tool
view.
OBSERVED RESULT
1. The commit message subject and body fields become disabled.
2. The git commit error message can be found in the Version Control tool view
if the user enables and makes it visible. For example:
```
/path/to/ktexteditor> git commit -m e
Command exited with value 1.
ERROR: You have unformatted changes, please format your files. You can do this
using the following commands:
git clang-format --force # format the changed parts
git clang-format --diff # preview the changes done by the formatter
Command finished with error UnknownError.
```
EXPECTED RESULT
1. The commit message subject and body fields remain enabled and editable.
2. The error with the actual `git commit` command output is shown to the user
in one way or another. For example:
a) the Version Control tool view becomes enabled and visible automatically;
b) the error is shown in the Git Commit tool view somewhere;
c) the error is shown at the top of the KDevelop window via
`ICore::self()->uiController()->postMessage()`.
d) the error is shown in a message box.
SOFTWARE/OS VERSIONS
Manjaro GNU/Linux, Xfce
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2+kde+r226
--
You are receiving this mail because:
You are watching all bug changes.
