https://bugs.kde.org/show_bug.cgi?id=441154
Lynx3d <lynx.mw+...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lynx.mw+...@gmail.com
--- Comment #4 from Lynx3d <lynx.mw+...@gmail.com> ---
Yeah I would just move the update() from slotEmitColorChanged() to
slotExternalFgColorChanged(), and also connect background color updates to
update(), because the popup palette is not truly modal, and also a reset may
only actually change the background color.
So relying on the selector re-emitting the change seems not the best choice
here.
In any case, avoid repaint(), that forces an immediate async repaint on every
call while update() schedules it for the next round of synchronized widget
repaints, which is more efficient.
Btw. commit b117b85f378f09027385f209a9333a43d3538dcc killed the right-click
reset functionality, but I'm not sure we should use right-click or that anyway,
because people need to be careful where to close the popup palette, especially
when using the canvas rotation feature of it.
--
You are receiving this mail because:
You are watching all bug changes.
