https://bugs.kde.org/show_bug.cgi?id=439622
Jan Paul Batrina <jpmbatrin...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/fram
| |eworks/kio/commit/9f6f1c550
| |6b714e049977a4868723b2b2529
| |aed4
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from Jan Paul Batrina <jpmbatrin...@gmail.com> ---
Git commit 9f6f1c5506b714e049977a4868723b2b2529aed4 by Jan Paul Batrina.
Committed on 29/08/2021 at 04:22.
Pushed by ahmadsamir into branch 'master'.
KFilePlaceEditDialog: Always preserve previous icon
When the original item's url is trash:/, m_iconButton wasn't
instantiated since isIconEditable() will return false. If the url is
edited to point somewhere else, isIconEditable() will return false,
making the check in KFilePlaceEditDialog::icon() fail to guard access
to m_iconButton which points to nullptr. This crash can be seen by
trying to change the "Trash" entry's location in Dolphin's Places panel.
This patch makes it so that m_iconButton is always instantiated to
prevent the crash and also to always preserve the original icon before editing.
M +16 -17 src/filewidgets/kfileplaceeditdialog.cpp
https://invent.kde.org/frameworks/kio/commit/9f6f1c5506b714e049977a4868723b2b2529aed4
--
You are receiving this mail because:
You are watching all bug changes.
