https://bugs.kde.org/show_bug.cgi?id=440759

--- Comment #10 from Gerald Cox <gb...@bzb.us> ---


(In reply to Michail Vourlakos from comment #9)
> I made a test. Please change the two lines you mentioned in CMakeLists file
> with:
> 
> #hide warnings
> string(REPLACE "-Wall" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
> string(REPLACE "-Wdeprecated-declarations" "" CMAKE_CXX_FLAGS
> ${CMAKE_CXX_FLAGS})
> string(REPLACE "-Wreorder" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
> string(REPLACE "-Wunused-variable" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
> string(REPLACE "-Wunused-parameter" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
> 
> #add format security check
> set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wformat -Werror=format-security")
> 
> 
> 1. I enforced the Fedora rule to check what errors are happening
> 2. Does it build in Fedora in that case?
> 3. In my system it with above changes it builds just fine. If it doesnt
> build in Fedora what warnings are considered errors and it is not built?

Yes, that builds fine!  Thanks for fixing!

I also ran with the trace option, the error is:

cc1plus: error: '-Wformat-security' ignored without '-Wformat'
[-Werror=format-security]

so that seems to imply that the errors are from removing the -Wformat and
Fedora adding the Werror=format-security.  Which would explain why when I also
removing it via the string REPLACE gets around the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to