https://bugs.kde.org/show_bug.cgi?id=438269
Dmitry Kazakov <dimul...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/krita/commit/06d2270b7
                   |                            |7c3681edfa783ab006b765c7772
                   |                            |be93
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 06d2270b77c3681edfa783ab006b765c7772be93 by Dmitry Kazakov.
Committed on 21/07/2021 at 06:44.
Pushed by dkazakov into branch 'master'.

Fix aspect button initialization in Blur filter

The bug was caused by a coincidence of four problems:

1) KoAspectButton never did initialization of the icon in the constructor,
   it waited for someone to call setKeepAspectRatio() to set up the icon

2) Constructor of KisWdgBlur never initialized m_halfSizeLink variable
   and the button.

3) [not fixed] KisWdgBlur::setConfiguration() (and a lot of other filters) just
skip
   initializing the GUI control in case the property is absent in the
   configuration. Ideally, it should fall back to the default value
   instead.

4) KisBlurFilter::defaultConfiguration() didn't add a property for
   "lockAspect", so the control has never been initialized unless the
   user clicked on it.

M  +7    -4    libs/widgets/KoAspectButton.cpp
M  +1    -0    plugins/filters/blur/kis_blur_filter.cpp
M  +3    -0    plugins/filters/blur/kis_wdg_blur.cpp

https://invent.kde.org/graphics/krita/commit/06d2270b77c3681edfa783ab006b765c7772be93

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to