[amarok] [Bug 438651] Amarok stalls if the Previous Track button is pressed but the file not longer exists

[Toni Asensi Esteve]

https://bugs.kde.org/show_bug.cgi?id=438651

--- Comment #8 from Toni Asensi Esteve <toni.ase...@kdemail.net> ---
In the tests that I performed, using the Standard mode (it utilizes
StandardTrackNavigator), everything worked as it was expected. Great! 

Using the Random Mode, if some track files do not exist: 
- The Previous Track button also works! 
- However, pressing the Next Track button sometimes fails.

INFORMATION THAT MAY HELP

Pedro Gomes lately made this improvement:

    Playlist::NonlinearTrackNavigator::requestLastTrack()
    {
        doItemListsMaintenance();

    -    quint64 lastItem = m_historyItems.isEmpty() ? 0 :
m_historyItems.takeLast();
    +    quint64 lastItem = 0;
    +    while (!m_historyItems.isEmpty())
    +    {
    +        quint64 possibleLastItem = m_historyItems.takeLast();
    +        if (m_model->trackForId(possibleLastItem)->isPlayable()) {
    +            lastItem = possibleLastItem;
    +            break;
    +        }
    +    }

        setCurrentItem( nextItem );
        return m_currentItem;
    }

Perhaps a similar change is needed in the following function?

    Playlist::NonlinearTrackNavigator::requestNextTrack()
    {
        doItemListsMaintenance();

        ItemList *donor = nextItemChooseDonorList();
        quint64 nextItem = donor ? donor->takeFirst() : 0;

        setCurrentItem( nextItem );
        return m_currentItem;
    }

Thanks for Amarok!

-- 
You are receiving this mail because:
You are watching all bug changes.