https://bugs.kde.org/show_bug.cgi?id=436170
Christoph Cullmann <cullm...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/fram
| |eworks/ktexteditor/commit/e
| |337a224309860e0bb50a61a0c01
| |2a474457bb29
--- Comment #7 from Christoph Cullmann <cullm...@kde.org> ---
Git commit e337a224309860e0bb50a61a0c012a474457bb29 by Christoph Cullmann, on
behalf of Ahmad Samir.
Committed on 06/06/2021 at 07:10.
Pushed by cullmann into branch 'master'.
WIP: Take into account wordCompletionRemoveTail in completionRange() default
implementation
If the wordCompletionRemoveTail option is enabled
CodeCompletionModelControllerInterface::completionRange() will return a
range containing the whole word the cursor is inside, which means that the
whole word will be replaced by the selected completion; however if that
option is disabled then it'll return a range containing only the part of
the word on the left of the cursor.
This simplifies the code:
- KateWordCompletionModel::completionRange() is now redundant (finding the
word start/end is already done in
CodeCompletionModelControllerInterface::completionRange())
- KateWordCompletionModel::executeCompletionItem() doesn't need to find the
end of the word being completed, less code
The Kate plugins that implement their own completion models, e.g.
KateProjectCompletion, can now remove their implementation of
completionRange() (which is a copy of
KateWordCompletionModel::completionRange());
and the LSPClient plugin completion model now should automatically follow the
wordCompletionRemoveTail config option.
M +1 -46 src/completion/katewordcompletion.cpp
M +0 -2 src/completion/katewordcompletion.h
M +5 -1 src/include/ktexteditor/codecompletionmodelcontrollerinterface.h
M +19 -9 src/utils/codecompletionmodelcontrollerinterface.cpp
https://invent.kde.org/frameworks/ktexteditor/commit/e337a224309860e0bb50a61a0c012a474457bb29
--
You are receiving this mail because:
You are watching all bug changes.
