https://bugs.kde.org/show_bug.cgi?id=434840
--- Comment #5 from Julian Seward <jsew...@acm.org> ---
(In reply to Carl Love from comment #4)
> Created attachment 136999 [details]
> patch to add darn instruction support
+ULong darn_dirty_helper ( UInt L )
+{
+
...
+# else
+ val = 0xFFFFFFFFFFFFFFFFULL; /* error */
+# endif
Given that you initialise `val` to the error value outside of any ifdef,
this #else clause is redundant. You could remove it.
+static Int dis_darn ( UInt prefix, UInt theInstr,
+ const VexAbiInfo* vbi )
..
+ if (L == 3)
+ /* Hardware reports illegal instruction if L = 3. */
+ vpanic("ERROR: darn instruction L=3 is not valid\n");
Generate SIGILL for an unrecognised instruction, don't assert.
Please always do this -- I've asked multiple times before.
--
You are receiving this mail because:
You are watching all bug changes.
