https://bugs.kde.org/show_bug.cgi?id=433770
Sharaf <sharafzaz...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
|hics/krita/commit/5ea95edb1 |hics/krita/commit/9ac750ab5
|f51acbac032055aee6333381efe |7607f3219ca4d444bc1e9ec6951
|95c8 |7e67
--- Comment #5 from Sharaf <sharafzaz...@gmail.com> ---
Git commit 9ac750ab57607f3219ca4d444bc1e9ec69517e67 by Sharaf Zaman.
Committed on 24/03/2021 at 10:39.
Pushed by szaman into branch 'krita/4.3'.
Bugfix: Crash with crop tool
The reason for crash was use after free, and the flow is like this:
1. User Crops the image (Crop gets added to Undo Stack)
2. User Undos the Crop (Crop is popped off that stack and is available
for Redo)
3. User makes a Crop Selection
4. User makes a Redo Action (Because the crop selection is active, prior
to the change we would apply the crop stroke which would purge the Redo
Stack, deleting the KisSavedMacroCommand* which later would be used in
KisSavedCommandBase::runStroke [its vtable]).
Since there is no stroke running during selection, we only have to clear
the selection.
(cherry picked from commit 5ea95edb1f51acbac032055aee6333381efe95c8)
M +1 -1 plugins/tools/tool_crop/kis_tool_crop.cc
https://invent.kde.org/graphics/krita/commit/9ac750ab57607f3219ca4d444bc1e9ec69517e67
--
You are receiving this mail because:
You are watching all bug changes.
