https://bugs.kde.org/show_bug.cgi?id=432215
Aaron Merey <ame...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #135525|0 |1
is obsolete| |
--- Comment #10 from Aaron Merey <ame...@redhat.com> ---
Created attachment 135885
--> https://bugs.kde.org/attachment.cgi?id=135885&action=edit
debuginfod.patch
(In reply to Mark Wielaard from comment #9)
> Do we really need to redirect stderr to a temporary file and then use grep
> to filter out any errors? If possible it would be nicer if we could simply
> do one exec and simply drain stderr from the process till it is done and
> then read stdout, which is always just one line with the file path. Did you
> try that?
So we need to drain stderr in case $DEBUGINFOD_PROGRESS or $DEBUGINFOD_VERBOSE
are set and possibly cause the pipe to fill up. But since this this output
doesn't work well with umesg() I just unset these environment variables in
the child process that exec's debuginfod-find. This way if there is an error
in debuginfod-find we are guaranteed a one line message in stderr which can be
printed with umesg(). In the valgrind manpage I mention that these environment
variables will be ignored. These changes plus the others you asked for are in
the revised attachment.
--
You are receiving this mail because:
You are watching all bug changes.
