https://bugs.kde.org/show_bug.cgi?id=432161

--- Comment #3 from Julian Seward <jsew...@acm.org> ---
Nicely done!  I did spot one bug though:

@@ -3752,6 +3775,8 @@ IRAtom* expr2vbits_Binop ( MCEnv* mce,

       case Iop_I32StoF32x4:
       case Iop_F32toI32Sx4:
+      case Iop_Sqrt16Fx8:
+         return unary16Fx8_w_rm(mce, vatom1, vatom2);
       case Iop_Sqrt32Fx4:
          return unary32Fx4_w_rm(mce, vatom1, vatom2);
       case Iop_Sqrt64Fx2:

This isn't quite right, in that the two added lines change the behaviour for
the fallthrough cases immediately above.  I mean: consider what happens for
Iop_I32StoF32x4 and Iop_F32toI32Sx4 with and without the added lines.

Otherwise it's fine.

One final question: did you check that the relevant test programs run OK
(without any assertion failures) on memcheck, by running them by hand, with
--tool=memcheck and also --tool=memcheck --track-origins=yes ?  If not, could
you please do that and make sure nothing breaks.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to