https://bugs.kde.org/show_bug.cgi?id=364590

Sven Brauch <m...@svenbrauch.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/kdev
                   |                            |platform/bb9dfe6dbee320fa34
                   |                            |49675cd492d344fe9b60f4
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from Sven Brauch <m...@svenbrauch.de> ---
Git commit bb9dfe6dbee320fa3449675cd492d344fe9b60f4 by Sven Brauch.
Committed on 26/06/2016 at 12:39.
Pushed by brauch into branch '5.0'.

Fix toolview hiding/showing

I can't even begin to describe how broken this was:
 - emptyChanged() was not emitted when a button was added
 - there was a timer firing every 100ms, always (!) checking
   whether to show the toolview
 - once a toolview was hidden the member storing the state could
   never change such that it would show again

CCMAIL:kf...@kde.org

This _probably_ fixes
because I suspect it happens when the toolviews are constructed before
plugins are loaded; then there are no buttons, and they are all hidden,
and will never be shown again.

M  +4    -0    sublime/idealbuttonbarwidget.cpp
M  +4    -23   sublime/mainwindow_p.cpp

http://commits.kde.org/kdevplatform/bb9dfe6dbee320fa3449675cd492d344fe9b60f4

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to