https://bugs.kde.org/show_bug.cgi?id=364582

Harald Sitter <sit...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/phon
                   |                            |on-vlc/6268ba35692acdb9cfdd
                   |                            |062a807f957f499fef2c
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Harald Sitter <sit...@kde.org> ---
Git commit 6268ba35692acdb9cfdd062a807f957f499fef2c by Harald Sitter.
Committed on 21/06/2016 at 13:12.
Pushed by sitter into branch '0.9'.

give libvlc a prefix, to avoid it preprocessing on libvlc_foo lines

i.e. technically we should always have
file header > qt include > vlc include > other include > other pvlc include
but apparently there is a case where this isn't being done so
utils/libvlc.h is included before the actual vlc headers which means by
the time the vlc headers are preprocessed the 'libvlc' macro was already
defined which then caused to it being applied to libvlc_foo_kitten_magic
which naturally resulted in compilation failure.

M  +3    -3    src/backend.cpp
M  +4    -4    src/devicemanager.cpp
M  +1    -1    src/effectmanager.cpp
M  +1    -1    src/media.cpp
M  +1    -1    src/mediaplayer.cpp
M  +2    -2    src/utils/libvlc.h

http://commits.kde.org/phonon-vlc/6268ba35692acdb9cfdd062a807f957f499fef2c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to