https://bugs.kde.org/show_bug.cgi?id=35333
Simon St James <kdede...@etotheipiplusone.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |RESOLVED
Latest Commit| |http://commits.kde.org/ktex
| |teditor/025edb11ca9b0fa3685
| |802e6c9cb608a4daa7911
--- Comment #2 from Simon St James <kdede...@etotheipiplusone.com> ---
Git commit 025edb11ca9b0fa3685802e6c9cb608a4daa7911 by Simon St James.
Committed on 18/06/2016 at 08:35.
Pushed by sstjames into branch 'master'.
Annoyingly, in Qt 5.5 we can no longer trigger shortcuts by replaying
QKeyEvents (something that the Vi Mode - which stores and swallows all key
events by default in case they are part of a Mapping and replays them if it
turns out they weren't - depends on), so if we are stealing shortcuts, they
will no longer be triggered e.g. pressing Ctrl+S will not save! This patch
reworks the whole mechanism, moving from "swallow all QKeyEvents and maybe
replay later" to "decide whether to swallow shortcuts, but if not, let Qt's
shortcut handling system despatch the QShortcutOverride itself". This mostly
fixes things, though we can't e.g. create a mapping that, when triggered, saves
the document or triggers any of Kate's shortcuts, plus some other small edge
cases :(
REVIEW:D1894
M +1 -1 src/inputmode/kateabstractinputmode.h
M +1 -1 src/inputmode/katenormalinputmode.cpp
M +1 -1 src/inputmode/katenormalinputmode.h
M +25 -22 src/inputmode/kateviinputmode.cpp
M +3 -1 src/inputmode/kateviinputmode.h
M +4 -2 src/vimode/emulatedcommandbar/emulatedcommandbar.cpp
M +2 -1 src/vimode/emulatedcommandbar/emulatedcommandbar.h
M +1 -1 src/vimode/inputmodemanager.cpp
M +28 -2 src/vimode/keymapper.cpp
M +7 -2 src/vimode/modes/normalvimode.cpp
http://commits.kde.org/ktexteditor/025edb11ca9b0fa3685802e6c9cb608a4daa7911
--
You are receiving this mail because:
You are watching all bug changes.
