https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #229 from Marcel <maes...@gmail.com> --- Created attachment 132064 --> https://bugs.kde.org/attachment.cgi?id=132064&action=edit asan error in CPGFMemoryStream Maik, the test run for a long time. I original error did not occur. Instead this one was shown after hours. What is now the change? Is it now just the removeOne() function? @Gilles. In my work place we also had discussions about this clang-tidy rule. Technically it can help in a few places to decrease the move effort. But we came up with the conclusion that the readability is lower and its error prune when copying from such a place. Therefore we decided to not to use this rule. Anyway, in my opinion there are other rules far more important for Digikam than this one. On my work place it turned out that a good way to go is: - Activate new rule and auto fix it - Most autofix problems turned out to be compiler errors es well. Fix them. - After applying, look for a compiler flag doing the same (e.g override) and apply it and treat warnings as errors With this way you also find the false positive and ensure that nobody in the future does it wrong again. If you like I could spend some time with that and send you a merge request... -- You are receiving this mail because: You are watching all bug changes.
