https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #195 from caulier.gil...@gmail.com --- Right Maik, I fixed some this-> entry in source code in the pass after a large cppcheck report about dynamic binding problem. This one is a fix by me. You are right, instead to use this->, we must use final-> c++11 keyword. Note : all dynamic binding fixed are annotated with a "NOTE: use dynamic binding" comment in source code. It's easy to double check all entries to see if this-> or final-> must be used at these places (32 entries). grep -r "NOTE: use dynamic" core/* ../../core/app/date/ddateedit.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/app/date/ddateedit.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/app/date/ddateedit.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/app/items/views/digikamitemview.cpp: // --- NOTE: use dynamic binding as slotSetupChanged() is a virtual method which can be re-implemented in derived classes. ../../core/app/items/thumbbar/itemthumbnailbar.cpp: // --- NOTE: use dynamic binding as slotSetupChanged() is a virtual slot which can be re-implemented in derived classes. ../../core/dplugins/rawimport/native/rawpostprocessing.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/libs/models/abstractalbummodel.cpp: // --- NOTE: use dynamic binding as all slots above are virtual methods which can be re-implemented in derived classes. ../../core/libs/database/models/itemmodel.cpp: // --- NOTE: use dynamic binding as slotImageChange() is a virtual slot which can be re-implemented in derived classes. ../../core/libs/database/models/itemmodel.cpp: // --- NOTE: use dynamic binding as slotImageTagChange() is a virtual slot which can be re-implemented in derived classes. ../../core/libs/dimg/filters/dimgthreadedfilter.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/libs/dimg/filters/raw/rawprocessingfilter.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/libs/dimg/filters/greycstoration/greycstorationfilter.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/libs/dimg/filters/greycstoration/greycstorationfilter.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/libs/widgets/itemview/itemviewcategorized.cpp: // --- NOTE: use dynamic binding as slots below are virtual methods which can be re-implemented in derived classes. ../../core/libs/widgets/layout/sidebar.cpp: // --- NOTE: use dynamic binding as slotClicked() is a virtual method which can be re-implemented in derived classes. ../../core/libs/widgets/metadata/subjectwidget.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/libs/widgets/metadata/subjectwidget.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/libs/properties/itempropertiessidebar.cpp: // --- NOTE: use dynamic binding as slotChangedTab() is a virtual method which can be re-implemented in derived classes. ../../core/libs/properties/import/importitempropertiessidebar.cpp: // --- NOTE: use dynamic binding as slotChangedTab() is a virtual method which can be re-implemented in derived classes. ../../core/libs/album/widgets/albumselectcombobox.cpp: // --- NOTE: use dynamic binding as updateText() is a virtual slot which can be re-implemented in derived classes. ../../core/libs/dialogs/infodlg.cpp: // --- NOTE: use dynamic binding as slotCopy2ClipBoard() is a virtual slot which can be re-implemented in derived classes. ../../core/libs/metadataengine/engine/metaengine.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/libs/threads/workerobject.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/showfoto/thumbbar/showfotothumbnailbar.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/utilities/maintenance/maintenancetool.cpp: // --- NOTE: use dynamic binding as slotCancel() is a virtual method which can be re-implemented in derived classes. ../../core/utilities/imageeditor/editor/editortool.cpp: // --- NOTE: use dynamic binding as slotPreview() is a virtual method which can be re-implemented in derived classes. ../../core/utilities/setup/metadata/namespaceeditdlg.cpp: // --- NOTE: use dynamic binding as slots below are virtual method which can be re-implemented in derived classes. ../../core/utilities/import/views/importiconview.cpp: // --- NOTE: use dynamic binding as slotSetupChanged() is a virtual method which can be re-implemented in derived classes. ../../core/utilities/import/views/importthumbnailbar.cpp: // --- NOTE: use dynamic binding as slotSetupChanged() is a virtual method which can be re-implemented in derived classes. ../../core/utilities/geolocation/geoiface/tiles/abstractmarkertiler.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. ../../core/utilities/geolocation/geoiface/bookmark/bookmarksmenu.cpp: // --- NOTE: use dynamic binding as slotAboutToShow() is a virtual method which can be re-implemented in derived classes. ../../core/utilities/geolocation/geoiface/bookmark/bookmarksmenu.cpp: // NOTE: use dynamic binding as this virtual method can be re-implemented in derived classes. Gilles -- You are receiving this mail because: You are watching all bug changes.
