https://bugs.kde.org/show_bug.cgi?id=422554

--- Comment #7 from Harald Sitter <sit...@kde.org> ---
Git commit f3c12f1201699b1c3de55fe56e9dbea5553996dc by Harald Sitter.
Committed on 20/08/2020 at 11:57.
Pushed by sitter into branch 'master'.

fix up ACE ordering

the order of entries within the ACL have meaning as samba aborts
permission lookup on matching denials but combines read and full access.
since our ACL table mimics windows' we'll follow its behavior as it's
also fairly easy to explain

"a denial always denies, no matter what other rules exist"

to that end we'll now sort the ACL to first list denials, then reads,
then full access

- if foo is denied they'll not be let in
- if bar is read they get let in
- if Everyone is denied nobody gets in

should we later add group support this further becomes

- if groupFoo is denied and bar is a member of it then bar is denied
- if groupBar is read and foo is a member of it then foo is still denied
- if groupFoo is fullacces and bar is a member they'll get fullaccess
FIXED-IN: 20.12

M  +39   -10   samba/filepropertiesplugin/model.cpp
M  +1    -0    samba/filepropertiesplugin/sambausershareplugin.cpp

https://invent.kde.org/network/kdenetwork-filesharing/commit/f3c12f1201699b1c3de55fe56e9dbea5553996dc

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to