https://bugs.kde.org/show_bug.cgi?id=425563

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kfilemetadata/commit
                   |                            |/915860e939fae264578ba8f67e
                   |                            |66a210d676a18e
   Version Fixed In|                            |5.74
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Nate Graham <n...@kde.org> ---
Git commit 915860e939fae264578ba8f67e66a210d676a18e by Nate Graham.
Committed on 20/08/2020 at 16:04.
Pushed by ngraham into branch 'master'.

Convert old Mac line endings in lyrics tags

Qt automatically converts Windows-style line endings (`\r\n`) but not
old Mac line endings (`\r`), probably because it is a platform that has
been dead for over 20 years. However some people have songs with embedded
lyrics tags that were encoded on that platform, and as a result, these
lyrics do not show up properly in various places where lyrics can be
viewed, such as Elisa's context view and dolphin's Information Panel.

This commit replaces old Mac line endings with conventional UNIX-style
line endings. Windows line endings are not affected because
`QLatin1Char('\r')` does not match the windows style line ending as it
is only a single character.
FIXED-IN: 5.74

M  +1    -1    src/extractors/taglibextractor.cpp

https://invent.kde.org/frameworks/kfilemetadata/commit/915860e939fae264578ba8f67e66a210d676a18e

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to