https://bugs.kde.org/show_bug.cgi?id=420051

--- Comment #6 from tus...@vista.aero ---
(In reply to wolthera from comment #5)
> Ok, so there's still the snapshots issue.
> 
> This one is kinda hairy as it's all weak reference pointer copy
> implementation magic.
> 
> But generally, what is happening is that the reference layer gets copied,
> but the canvas decorations aren't updated (specifically, 
> KisReferenceImagesDecoration::
> setReferenceImageLayer(KisSharedPtr<KisReferenceImagesLayer> layer) needs to
> be called for the changing snapshot), and I am not sure where to do that...

Looks like I am able to fix the bug that the reference images are not shown,
but the ref images cannot automatically update after a switch. This is probably
due to tiar's fix of
https://invent.kde.org/graphics/krita/-/commit/311d804aa23f1993ec19513cdd90ad0758627f3c
because:

[1] d->layer->extent() is always QRectF() # I think this is problematic.
[2] slotReferenceImagesChanged() (i.e. the update canvas part) will not be run
if extent is empty # tiar thinks extent == QRectF() implies the layer is not
loaded yet. But this is not the case.
[3] As a result, slotReferenceImagesChanged() will never run.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to