https://bugs.kde.org/show_bug.cgi?id=416762
Dan Leinir Turthra Jensen <ad...@leinir.dk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kne
| |wstuff/25d391c6f36b16a9c4f6
| |85de1e6e8d1a5d9d71b4
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #3 from Dan Leinir Turthra Jensen <ad...@leinir.dk> ---
Git commit 25d391c6f36b16a9c4f685de1e6e8d1a5d9d71b4 by Dan Leinir Turthra
Jensen.
Committed on 06/05/2020 at 08:43.
Pushed by leinir into branch 'master'.
Fix showing updates when the option is selected
Summary:
This patch primarily fixes the issue that when picking the "Updateable Only"
option on NewStuff.Page, we would be shown all the entries anyway. It also
fixes duplicated entries on the "Installed Only" option, and further adds a
little placeholder for when the view is expectedly empty.
* Use the right connections for update entry display
* While potentially expensive, only add entries to the model once
* Use Kirigami.PlaceholderMessage to show we have no entries when we don't
Test Plan:
Without this patch, behaviour is as shown in
https://bugs.kde.org/show_bug.cgi?id=416762
With this patch, the behaviour is as expected (shows only updateable entries
with that option selected, only shows installed entries once with that option,
and shows a useful message when the list is empty and expected to be empty)
Reviewers: #knewstuff, #plasma, bugseforuns, ngraham, #frameworks
Reviewed By: ngraham
Subscribers: alex, kde-frameworks-devel
Tags: #frameworks, #plasma, #knewstuff
Differential Revision: https://phabricator.kde.org/D29447
M +15 -12 src/core/itemsmodel.cpp
M +11 -1 src/qtquick/qml/Page.qml
M +10 -1 src/qtquick/quickitemsmodel.cpp
https://commits.kde.org/knewstuff/25d391c6f36b16a9c4f685de1e6e8d1a5d9d71b4
--
You are receiving this mail because:
You are watching all bug changes.
