https://bugs.kde.org/show_bug.cgi?id=419959

Dan Leinir Turthra Jensen <ad...@leinir.dk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kne
                   |                            |wstuff/12642a1c0174bb4f0cd3
                   |                            |163fee9f8e66f5959c32
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Dan Leinir Turthra Jensen <ad...@leinir.dk> ---
Git commit 12642a1c0174bb4f0cd3163fee9f8e66f5959c32 by Dan Leinir Turthra
Jensen.
Committed on 04/05/2020 at 10:46.
Pushed by leinir into branch 'master'.

Fix update auto selection

Summary:
The new autoselection for updating installed entries would firstly
not be looking at the right amount of download links, and further it
would not be able to identify the links it needed to, as it did not
look at the descriptive names (where the filename is often stored),
which then would not match. These changes ensure that we look at
the right bits of information when doing this check. End result is
that updating works.

* Ensure that the cache doesn't forget installing and updating items
* Analyse more of the download link information, and use correct counts

Test Plan:
Find an item in some KNS dialog in need of updating, and click the Update
button

On the console, when launched using the correct logging categories, will
tell you about the selection process (and the UI will show that an update
is in progress, and eventually that it is completed). To do this check with
the icons kcm, run it like so:

  QT_LOGGING_RULES="org.kde.knewstuff*=true" kcmshell5 kcm_icons

Reviewers: #frameworks, #plasma, bugseforuns, ngraham, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D29222

M  +7    -1    src/core/cache.cpp
M  +28   -4    src/core/engine.cpp

https://commits.kde.org/knewstuff/12642a1c0174bb4f0cd3163fee9f8e66f5959c32

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to