https://bugs.kde.org/show_bug.cgi?id=417780
David Redondo <k...@david-redondo.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/pla
| |sma-framework/b7fa6e0e916bd
| |8856cbf85b2d3886bc1e7b0e278
Status|CONFIRMED |RESOLVED
--- Comment #7 from David Redondo <k...@david-redondo.de> ---
Git commit b7fa6e0e916bd8856cbf85b2d3886bc1e7b0e278 by David Redondo.
Committed on 02/03/2020 at 10:55.
Pushed by davidre into branch 'master'.
Try to apply the colorscheme of the current theme to QIcons
Summary:
Before icons loaded internally with QIcon::fromTheme were being colored with
the
colors from the current global color scheme instead of the ones from the
current
Plasma Theme. Leading to visual bugs when the two differ. This happened because
KIconLoader uses the global color scheme by default.
A prominent case is the notification send by the network plasmoid when one
successfully connected to a wireless network. It sets the icon
"network-wireless-on" which is not included in Breeze icons (but is included in
Breeze Plasma Theme). If the current icon theme is indeed Breeze, IconItem
resorts to using QIcon::fromTheme and we end up with a wrong colored
"network-wireless" icon.
Test Plan:
{F8125752}
{F8125753}
Reviewers: #plasma, cblack, ngraham, mart
Reviewed By: #plasma, cblack, ngraham, mart
Subscribers: mart, wbauer, cblack, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D27589
M +4 -0 src/declarativeimports/core/iconitem.cpp
M +2 -0 src/plasma/private/theme_p.cpp
M +1 -0 src/plasma/private/theme_p.h
M +6 -0 src/plasma/theme.cpp
M +8 -0 src/plasma/theme.h
https://commits.kde.org/plasma-framework/b7fa6e0e916bd8856cbf85b2d3886bc1e7b0e278
--
You are receiving this mail because:
You are watching all bug changes.
