https://bugs.kde.org/show_bug.cgi?id=363279
Friedrich W. H. Kossebau <kosse...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |http://commits.kde.org/krit
| |a/4a3058a511766761cea7a6b79
| |6e03f38c301cb12
Status|UNCONFIRMED |RESOLVED
--- Comment #2 from Friedrich W. H. Kossebau <kosse...@kde.org> ---
Git commit 4a3058a511766761cea7a6b796e03f38c301cb12 by Friedrich W. H.
Kossebau.
Committed on 20/05/2016 at 08:36.
Pushed by kossebau into branch 'master'.
Fix assert triggered for unbalanced unlock on (auto)save
Summary:
KisDocument::Private::SafeSavingLocker uses a member
KisImageBarrierLockAdapter m_imageLock to do the locking of KisImage.
Which it explicitely locks and unlocks again, to keep locking in balance,
together with std::try_lock.
But KisImageBarrierLockAdapter in its deconstructor unconditionally also
calls unlock on the image, without taking into account any state of other
unlock/lock calls.
Which then triggers the Q_ASSERT(locked()); in KisImage::unlock().
Reviewers: dkazakov, #krita:_next
Reviewed By: dkazakov, #krita:_next
Differential Revision: https://phabricator.kde.org/D1645
M +0 -1 libs/image/kis_image_barrier_lock_adapter.h
http://commits.kde.org/krita/4a3058a511766761cea7a6b796e03f38c301cb12
--
You are receiving this mail because:
You are watching all bug changes.
