https://bugs.kde.org/show_bug.cgi?id=410624

Harald Sitter <sit...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |19.12.3
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kio
                   |                            |-extras/7f47119b22d526fd2ff
                   |                            |d9451a9513dfb260a6706

--- Comment #4 from Harald Sitter <sit...@kde.org> ---
Git commit 7f47119b22d526fd2ffd9451a9513dfb260a6706 by Harald Sitter.
Committed on 13/02/2020 at 11:16.
Pushed by sitter into branch 'master'.

smb: retain atime properly

Summary:
this was broken since forever I guess. when the .part resume tech was
added it didn't correctly retain the access time. it was trying to
get the atime of 'file', but 'file' when resuming refers to the .part which
was deleted prior to the mtime adjustment so the QFileInfo(file).lastRead
would produce an Invalid QDateTime which then results in us setting random
nonesense as access time on the file.
instead simply use dstFile. it is the path of the actual final destination
file of which the atime is **actually** the one we want to preserve here
considering we've literally just accessed that file by copying it ^^
FIXED-IN: 19.12.3

Test Plan: copy file form smb to local has sound atime

Reviewers: ngraham, meven

Reviewed By: meven

Subscribers: kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D27352

M  +1    -1    smb/kio_smb_dir.cpp

https://commits.kde.org/kio-extras/7f47119b22d526fd2ffd9451a9513dfb260a6706

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to