https://bugs.kde.org/show_bug.cgi?id=417187

--- Comment #5 from Julian Seward <jsew...@acm.org> ---
(In reply to Stefan Maksimovic from comment #0)
> Created attachment 125689 [details]
> enable_grail_mips.diff

Just as a tiny comment on this patch, and not related to the main problem here:
the patch looks reasonable, except for this:

--- a/VEX/priv/ir_defs.c
+++ b/VEX/priv/ir_defs.c
@@ -5285,6 +5285,7 @@ Bool eqIRRegArray ( const IRRegArray* descr1, const
IRRegArray* descr2 )
 Int sizeofIRType ( IRType ty )
 {
    switch (ty) {
+      case Ity_I1:
       case Ity_I8:   return 1;
       case Ity_I16:  return 2;
       case Ity_I32:  return 4;

That just can't be right.  To ask for the byte size for Ity_I1 is more or
less meaningless -- it is (conceptually) a single bit.   Whatever you
commit, please don't commit this change.  Why is this necessary?  Maybe
we can find a different solution to whatever problem this solves.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to