https://bugs.kde.org/show_bug.cgi?id=385942
--- Comment #30 from Kai Uwe Broulik <k...@privat.broulik.de> ---
I tried to investigate a little but I think this code makes wrong assumptions.
On one hand it just casually does QUrl::toString() which by default uses
QUrl::PrettyDecoded, which tries to avoid as much percent-encoding as possible
and as such leaves spaces in tact. On the other hand, the code tries to ignore
garbage URLs and as such explicitly constructs URLs with QUrl::StrictMode.
Doing QUrl(url.toString(), QUrl::StrictMode) will naturally produce invalid
URLs when the original contained spaces leading to this bug. Using
QUrl::toString(FullyDecoded) somewhat works but isn't allowed for this option
according to Qt documentation for whatever reason. It would then also result in
QUrl("Garbage URL") being treated as valid.
I suggest to drop all of this StrictMode stuff and instead verify if the URL
scheme is valid (either file, applications, or preferred).
--
You are receiving this mail because:
You are watching all bug changes.
