https://bugs.kde.org/show_bug.cgi?id=389894
David Redondo <k...@david-redondo.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/spe
| |ctacle/9658891adf8275ac69d8
| |74e8753b92dd20060618
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Version Fixed In| |19.12.0
--- Comment #3 from David Redondo <k...@david-redondo.de> ---
Git commit 9658891adf8275ac69d874e8753b92dd20060618 by David Redondo.
Committed on 27/12/2019 at 14:49.
Pushed by davidre into branch 'master'.
Port towards KConfig XT
Summary:
Port settings to Kconfig XT. This enables us to drop our own settings class and
our own configuration dialog logic with it's logic. Setting the objectNames of
the Widgets accordingly enables us to reuse them.
The settings not managed through the Dialog (last save locations and screenshot
options in the main window) are written now on exit but are still instant
apply.
Using this opportunity this also unifies the naming style and moves some
settings inside the config file around: In general they are now in the same
group
as they are in the settings dialog. Additionally [Save] includes
lastSave(As)Location, too. In [GuiConfig] are the options which are set in the
main window and the last crop region.
Also includes a behavioral change: "Open Screenshots Folder" will now open the
default folder as configured. The folder with the the last saved screenshot can
be opened from the inline message when saving.
FIXED-IN: 19.12.0
Test Plan: Works as before but the dialog has now more buttons
Reviewers: #spectacle, ngraham
Reviewed By: #spectacle, ngraham
Subscribers: guoyunhe, ervin, crossi, ngraham
Tags: #spectacle
Differential Revision: https://phabricator.kde.org/D23316
M +4 -0 desktop/CMakeLists.txt
A +23 -0 desktop/spectacle_newConfig.upd
M +4 -3 src/CMakeLists.txt
M +16 -19 src/ExportManager.cpp
M +25 -42 src/Gui/KSMainWindow.cpp
M +1 -1 src/Gui/KSMainWindow.h
M +29 -29 src/Gui/KSWidget.cpp
M +52 -71 src/Gui/SettingsDialog/GeneralOptionsPage.cpp
M +2 -26 src/Gui/SettingsDialog/GeneralOptionsPage.h
M +32 -87 src/Gui/SettingsDialog/SaveOptionsPage.cpp
M +9 -24 src/Gui/SettingsDialog/SaveOptionsPage.h
M +35 -49 src/Gui/SettingsDialog/SettingsDialog.cpp
M +10 -14 src/Gui/SettingsDialog/SettingsDialog.h
D +0 -33 src/Gui/SettingsDialog/SettingsPage.cpp
D +0 -45 src/Gui/SettingsDialog/SettingsPage.h
M +30 -9 src/Gui/SettingsDialog/ShortcutsOptionsPage.cpp
M +29 -8 src/Gui/SettingsDialog/ShortcutsOptionsPage.h
A +6 -0 src/Gui/SettingsDialog/settings.kcfgc
A +124 -0 src/Gui/SettingsDialog/spectacle.kcfg
M +4 -1 src/Main.cpp
M +9 -9 src/QuickEditor/QuickEditor.cpp
A +101 -0 src/ShortcutActions.cpp [License: GPL (v2+)]
A +43 -0 src/ShortcutActions.h [License: GPL (v2+)]
D +0 -427 src/SpectacleConfig.cpp
D +0 -151 src/SpectacleConfig.h
M +20 -28 src/SpectacleCore.cpp
M +12 -4 tests/CMakeLists.txt
https://commits.kde.org/spectacle/9658891adf8275ac69d874e8753b92dd20060618
--
You are receiving this mail because:
You are watching all bug changes.
