https://bugs.kde.org/show_bug.cgi?id=415263

--- Comment #2 from Alexander Potashev <aspotas...@gmail.com> ---
(In reply to Christophe Giboudeaux from comment #1)
> No need, the doc already says it must be used with the 'executable target':
> 
> « # will be added to the executable target whose sources are specified by
> # ``<sources_var>`` »

This phrase does not imply that the sources must be added into add_executable()
directly.

In a case when you have part of application code (defined in variable
MYLIB_SOURCES) compiled into library "mylib", the condition "whose sources are
specified by MYLIB_SOURCES" still holds true. However the icon will not be
added into the executable target.

Our discussion also proves that this existing sentence is hard to read and
understand correctly.


Also, I think saying the same thing twice in different words is not bad.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to