https://bugs.kde.org/show_bug.cgi?id=274931
--- Comment #33 from Jim Duchek <jim.duc...@gmail.com> --- (In reply to Martin Gräßlin from comment #32) > The reason for the noborder check is explained in: > http://commits.kde.org/kwin/ff82383f8d8acdc684468a3176e1d048a795209b > > By simply reverting as asked for in this bug report, we are ignoring the > problems outlined in this commit. This needs a smarter solution. The solution has already been implemented, and the noborder check is a leftover. I don't have the time right now to dig out all the proper commits (but I will tomorrow if you want me to :).... you'll note in the HEAD version of manage.cpp, there is no more 'isOnAllActivities()' check as there was in this commit, because the proper way for windows to ask to be on all activities has been implemented. There is an additional comment just below the commit you referenced in manage.cpp: //TODO: if we are keeping it (at least as an option), replace noborder checking //with a public API for setting windows to be on all activities. //something like KWindowSystem::setOnAllActivities or //KActivityConsumer::setOnAllActivities And hi there... Client::setOnAllActivities() exists now -- there is no reason for this hack anymore, although it may potentially be masking bugs in other places wherein they are not properly asking for an all-activities window. But that is their bug to fix, and no reason to keep this one. This TODO needs to be removed along with the noborder check as well, I guess, lest it confuse future code browsers. The commit comment makes one still-valid point, in that indeed, users who WANT a no-border window to be on all activities, will need to figure out alt-f3, which is not obvious... But that is better than the current situation, wherein users who want no-border windows to act 'normally' have to figure out alt-f3. Somebody's going to need to find alt-f3 either way when it comes to no-border windows, and IMHO it should be the people who want the non-standard behavior. Jim -- You are receiving this mail because: You are watching all bug changes.
