https://bugs.kde.org/show_bug.cgi?id=414362
Bug ID: 414362
Summary: Bring back the old file changed dialog
Product: kate
Version: Git
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: kwrite-bugs-n...@kde.org
Reporter: nfx...@gmail.com
Target Milestone: ---
SUMMARY
Lately (maybe up to a year ago), kate was changed such that if a file changes
on filesystem (and the change is not between two git commits), it does not show
the modal KateMwModOnHdDialog anymore, but instead a sort of "popup" on the top
of the text editing window.
I think this is a negative change for the following reasons:
1. a user will notice the change only when opening the file (as in, selecting
it as the current buffer, even if it's already opened). You don't get an
overview over what has changed, or you will only notice a longer time later.
2. this does not block editing. You can continue editing and ignore this popup,
making the situation worse, or unknowingly overwriting the version on
filesystem by hitting the save file shortcut.
3. the popup has a button that makes a permanent choice; dangerous, and
requires the user to search through the preferences dialog to disable it again
(bad UX), from what I understand.
4. the popup's appearance and disappearance is animated, which is slow and
moves the text around, which is irritating.
5. what do you do if you intentionally changed the state on filesystem, and
want to either keep or reload all changed files? I guess you could manually go
to each file, or just to reload all files, but still worse than the old state.
While the old dialog was maybe not the best UI around, it was still better than
the current behavior.
I'm not sure when this happened; I think it's due to ktexteditor, since the
KateMwModOnHdDialog class is still in the kate source code, and just reverting
to an old kate commit didn't restore the behavior. Bisecting is a bit hard
because of all the interdependencies.
STEPS TO REPRODUCE
1. load a kate session (which is using the git project plugin I guess)
2. open 2 files (and optionally open to a third file)
3. change the two files using some other program
OBSERVED RESULT
When focusing the editor again, nothing happens until you navigate back to one
of the changed files. If you do, an animated popup appears on the top of the
editing window, which asks you whether to reload. You can ignore the popup.
EXPECTED RESULT
Focusing kate again shows a modal dialog that lists the changed files (no
matter which file is currently focused), and gives options to reload and
overwrite the files. Editing is blocked.
--
You are receiving this mail because:
You are watching all bug changes.
