https://bugs.kde.org/show_bug.cgi?id=369509
Julian Seward <jsew...@acm.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsew...@acm.org
--- Comment #2 from Julian Seward <jsew...@acm.org> ---
Mostly this looks fine. Thanks for the attention to detail and for following
the house style.
My only big concern here is the lack of hwcaps support in Vex/Valgrind. That
could be done in a followup bug, but it needs to happen fairly soon. I can
provide guidance. Let me ask: are the 8.1 extensions a single all-or-nothing
thing (meaning, they have to be all implemented, or none?) Or are they split
up into smaller subsets of instructions, and each group of instructions can be
implemented or not implemented?
There are also some smaller points directly with the patch:
> + && (INSN(15,15) == 0 || INSN(15,12) == BITS4(1,0,0,0))
I'd prefer this just to be INSN(15,12) <= BITS4(1,0,0,0)
+ stmt( IRStmt_Exit(
+ binop(Iop_CmpNE64,
+ widenUto64(ty, mkexpr(old)),
+ widenUto64(ty, mkexpr(orig))),
+ Ijk_Boring, nia, OFFB_PC ));
You need to use CasCmpNE64, not CmpNE64 here. For the reason see libvex_ir.h
defn of CasCmpNEXX.
+# Does the C compiler support the armv81 features flag
+# Note, this doesn't generate a C-level symbol. It generates a
+# automake-level symbol (BUILD_ARMV81_TESTS), used in test Makefile.am's
This is important, but it's not enough. We also need to check that the
assembler can assemble the instructions. The way to do that is to change the
test program (from "int main() { return 0; }") so that it has a bit of inline
assembly containing one of the relevant instructions. For an example, see
(eg)
AC_MSG_CHECKING([for VSX support in the assembler ])
in that file.
--
You are receiving this mail because:
You are watching all bug changes.
