https://bugs.kde.org/show_bug.cgi?id=412998

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kcm
                   |                            |utils/aea58fcca35984fff73e1
                   |                            |c77dc2edb346da4e69b
         Resolution|---                         |FIXED
             Status|REPORTED                    |RESOLVED

--- Comment #8 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit aea58fcca35984fff73e1c77dc2edb346da4e69b by David Edmundson.
Committed on 17/10/2019 at 09:09.
Pushed by davidedmundson into branch 'master'.

Fix memory leak of KQuickAddons::ConfigModule objects

Summary:
When we create a KQuickAddons::ConfigModule  in the factory we didn't
set a parent. It is passed to the wrapper KCModuleQML, and even though
the wrapper is memory manager the ConfigModule object itself was not.

This lead to another crash as the KAboutData is deleted twice, which was
fixed with an explicit copy

Test Plan:
qDebug inside the colours KCM destructor
It now appears when changing tabs

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24716

M  +2    -2    src/kcmoduleloader.cpp
M  +19   -17   src/kcmoduleqml.cpp
M  +1    -1    src/kcmoduleqml_p.h

https://commits.kde.org/kcmutils/aea58fcca35984fff73e1c77dc2edb346da4e69b

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to