https://bugs.kde.org/show_bug.cgi?id=412184

David Redondo <k...@david-redondo.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/spe
                   |                            |ctacle/34484c935c5c6ea91f11
                   |                            |bc69791ca43e18022016
   Version Fixed In|                            |19.08.3
         Resolution|---                         |FIXED

--- Comment #11 from David Redondo <k...@david-redondo.de> ---
Git commit 34484c935c5c6ea91f11bc69791ca43e18022016 by David Redondo.
Committed on 10/10/2019 at 10:17.
Pushed by davidre into branch 'Applications/19.08'.

Make all buttons in the main window activatable with enter

Summary:
In a QDialog QPushbuttons will have autoDefault==true and the Dialog will call
setDefault(true) on them. This allows the user to activate the Buttons with the
enter key. However we also use QToolButtons in the main window with no visible
difference to the user. This caused unexpected activations of the help button
(the first default button) when a tool button was focused. In a custom event
handler we can check if the current focused widget is tool or push button when
the enter key is pressed and activate them accordingly.
FIXED-IN: 19.08.3

Reviewers: #spectacle, ngraham

Reviewed By: #spectacle, ngraham

Subscribers: ngraham, aprcela, #spectacle

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D24508

M  +24   -0    src/Gui/KSMainWindow.cpp
M  +2    -0    src/Gui/KSMainWindow.h

https://commits.kde.org/spectacle/34484c935c5c6ea91f11bc69791ca43e18022016

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to