https://bugs.kde.org/show_bug.cgi?id=376940

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.17.0
      Latest Commit|                            |https://commits.kde.org/kin
                   |                            |focenter/1c7f121073a773c333
                   |                            |b6886333a209235cdc89b4
             Status|REPORTED                    |RESOLVED

--- Comment #2 from Nate Graham <n...@kde.org> ---
Git commit 1c7f121073a773c333b6886333a209235cdc89b4 by Nate Graham, on behalf
of Alex Debus.
Committed on 16/09/2019 at 17:06.
Pushed by ngraham into branch 'master'.

Add time line to X axis

Summary:
The current energy plot does not display any time line. This patch adds a grid
and time stamps to the X axis.
It is assumed that the X axis of the plot ranges over [Now - Timespan, Now].

The timestamps for the timespans greater than "1 hour" are aligned to either
half hours or full hours.
The resolution respectively the divisions count or number of ticks is made
dependend on the timespan.
Dates are only shown if the date changes in the timespan.

If there are more or equal 10 divisions, only every second grid line gets a
label to avoid that
the labels pile up, when the window size becomes small.

This patch may be only of temporary nature until [[
https://invent.kde.org/kde/kf5quickcharts | kf5quickcharts ]] becomes
production ready.
FIXED-IN: 5.17.0

As QML was absolutely new to me, I am looking forward to your review.

Test Plan:
{F7320952}
{F7320951}
{F7320950}

Reviewers: #vdg, ngraham, #plasma

Reviewed By: #vdg, ngraham

Subscribers: meven, bcooksley, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23520

M  +132  -20   Modules/energy/package/contents/ui/Graph.qml
M  +16   -1    Modules/energy/package/contents/ui/main.qml

https://commits.kde.org/kinfocenter/1c7f121073a773c333b6886333a209235cdc89b4

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to