https://bugs.kde.org/show_bug.cgi?id=411396

--- Comment #5 from Karl Ove Hufthammer <k...@huftis.org> ---
(In reply to Øystein Steffensen-Alværvik from comment #4)
> I just added a review to KRename, and my locale is Norwegian Nynorsk, so it
> should be visible for Hufthammer (if the reviews are not linked to specific
> distros?).

I can confirm that KRename now displays this review. So it looks like Discover
only shows reviews for the user’s main language. This either a bug in the ODRS
service or in Discover (or both):

According to https://odrs.gnome.org/, it seems like user’s language/locale
should only be used to *sort* the reviews: ‘By specifying the users current
locale we can sort the potential application reviews according to a heuristic
that we're still working on. Generally we want to prefer useful reviews in the
users locale […]’. But reviews written in other languages are not shown *at
all*, not just sorted at the bottom – so a bug in the ODRS service? (And I
guess many reviews marked as being in a non-English locale are actually written
in English, making this even more problematic.)

On the other hand, the KDE language/locale settings allow a *prioritised* list
of languages (for example, my list is set to ‘Norwegian Nynorsk; Norwegian
Bokmål; Danish; British English; American English’). So if the ODRS only
returns reviews in the submitted locale, Discover should ask for reviews in all
of the user’s languages and show them sorted by the preferred language. And
perhaps reviews written in English should *always* be fetched? (Just like the
UI in KDE applications are shown in English if the application hasn’t been
translated into *any* of the user’s preferred languages.)

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to