https://bugs.kde.org/show_bug.cgi?id=376179
Tymond <tamtamy.tym...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
|krita/commit/3602c72493b78d |krita/commit/1c65c4c04d84aa
|7e787911e60f3680371778f2ec |bcaaa29e9981a3e725a1d26f5a
--- Comment #4 from Tymond <tamtamy.tym...@gmail.com> ---
Git commit 1c65c4c04d84aabcaaa29e9981a3e725a1d26f5a by Agata Cacko.
Committed on 14/09/2019 at 15:25.
Pushed by tymond into branch 'krita/4.2'.
Fix Strength not used in Rotation - Fuzzy Dab
Before this commit, if you chose Fuzzy Dab sensor
in Rotation option, the value of the Strength slider wouldn't
affect the resulting rotation of the brush tip.
This commit fixes that behaviour: now if you choose very low
Strength and the first curve from the template ones,
the brush tip will rotate only slightly (before it would rotate
within the full 360* range).
* Fuzzy Dab is 'additive' kind of sensor, so it's value would be put
in 'realAdditivePart' in rotationLikeValue(). 'constant' contains the
value of 'Strength' slider. To get it working together,
'realAdditivePart' had to be multiplied by the 'constant' value.
* HSV option just ignored the problem and multiplied it by the value of
the slider later. It couldn't be done for Rotation because Rotation
takes the canvas rotation into account (see rotationLikeValue).
Therefore it had to be done inside rotationLikeValue function, not
later. Therefore the multiplication in HSV option had to be disabled
to not double the effect.
BACKPORT:krita/4.2
M +1 -1 plugins/paintops/libpaintop/kis_curve_option.h
M +0 -1 plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp
https://invent.kde.org/kde/krita/commit/1c65c4c04d84aabcaaa29e9981a3e725a1d26f5a
--
You are receiving this mail because:
You are watching all bug changes.
