https://bugs.kde.org/show_bug.cgi?id=409275
--- Comment #8 from Boudewijn Rempt <b...@valdyas.org> --- Git commit df7f7a9ac7e49a44ef83062c19a3d62510a0ad49 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 31/07/2019 at 08:39. Pushed by rempt into branch 'krita/4.2'. Make shape painting tools unblocking (use strokes) Opening a waiting dialog may make the shortcuts matcher unhappy, so we should avoid that. Related: bug 409968, bug 408826 M +3 -4 libs/ui/tool/kis_tool_shape.cc M +1 -2 plugins/tools/basictools/kis_tool_ellipse.cc M +42 -25 plugins/tools/basictools/kis_tool_gradient.cc M +1 -3 plugins/tools/basictools/kis_tool_rectangle.cc M +0 -2 plugins/tools/tool_polygon/kis_tool_polygon.cc M +0 -3 plugins/tools/tool_polyline/kis_tool_polyline.cc https://invent.kde.org/kde/krita/commit/df7f7a9ac7e49a44ef83062c19a3d62510a0ad49 --- Comment #9 from Boudewijn Rempt <b...@valdyas.org> --- Git commit dc6bf17a96556c930f63e4cfbd42591f79987573 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 31/07/2019 at 08:39. Pushed by rempt into branch 'krita/4.2'. Make KisShortcutMatcher be more tolerant to recursive entering Some tools, e.g. text tool, may open a dialog right inside beginPrimaryAction() callback. It may make KisShortcutMatcher crazy, because all the modal dialogs have hey own event loop, therefore the state machine of the shortcuts matcher will be broken. This patch makes the matcher a bit more tolerant to such faults. It just manually checks if it is entered more that once, and resets the action in case a recursion is detected. Related: bug 409968, bug 408826 M +168 -30 libs/ui/input/kis_shortcut_matcher.cpp M +1 -0 libs/ui/input/kis_shortcut_matcher.h https://invent.kde.org/kde/krita/commit/dc6bf17a96556c930f63e4cfbd42591f79987573 -- You are receiving this mail because: You are watching all bug changes.
