https://bugs.kde.org/show_bug.cgi?id=384837

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |ndowsystem/b485043e5633b9a0
                   |                            |7e3cc6804a66ddbe2c134583
             Status|REPORTED                    |RESOLVED

--- Comment #8 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit b485043e5633b9a07e3cc6804a66ddbe2c134583 by David Edmundson.
Committed on 26/07/2019 at 09:48.
Pushed by davidedmundson into branch 'master'.

[platforms/xcb] Use XRES extension to get real window PID

Summary:
It's increasingly common for apps to be in their own PID namespace. If
this is the case, they report a buggy NET_WM_PID on their windows as
obviously they don't know their own PID.

This patch uses the XResources extension to query the real PID instead
of asking the window.

This allows the task manager to know the real PID when doing lookups for
matching services or showing pulseaudio badges.

Querying the NET_WM_PID with the NETWM wrappers remains unchanged, so we
still have access to all information should a system need it.

Test Plan:
The relevant unit test KWindowInfo::testPid() still passes whilst using
this new extension.

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22755

M  +1    -1    CMakeLists.txt
M  +1    -0    src/platforms/xcb/CMakeLists.txt
M  +36   -0    src/platforms/xcb/kwindowinfo.cpp
M  +1    -0    src/platforms/xcb/kwindowinfo_p_x11.h

https://commits.kde.org/kwindowsystem/b485043e5633b9a07e3cc6804a66ddbe2c134583

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to